2015-06-03 17:42 GMT+02:00 Ron W <ronw.m...@gmail.com>:
> On Wed, Jun 3, 2015 at 10:24 AM, Jan Nijtmans <jan.nijtm...@gmail.com>
> wrote:
>>
>> 2015-04-25 1:29 GMT+02:00 Ron W <ronw.m...@gmail.com>:
>> > Would it be reasonable for Fossil to have a setting, or option in the
>> > diff/gdiff command setting, to indicate that relative paths should be
>> > supplied?
>>
>> You suggestion has been heard, and it's fixed here:
>> <http://www.fossil-scm.org/index.html/info/3ffb6a3e6299e92f>
>> (at least for this specific case, I'm sure there are more ...)
>
>
> Thinking about it, probably the PGP and SSH external commands, as well.
Well, my change has been put aside, as being a "Breaking change".
I fundamentally disagree with that, but I would like to hear Joe's arguments
about that. So, Joe, please explain! My guess is that Joe was mislead
by the comment, without looking at the code at all: It's not the path
of the external tool (diff/pgp/ssh) that's modified (therefore the PGP/SSH
suggestion is not valid, sorry ...), that would indeed
be a breaking change. It's just taking care that the _arguments_
provided to the external diff tool are relative paths in stead
of absolute paths, as is done almost everywhere else in fossil
(e.g. when calling the commit/stash comment editor).
@Joe: please, evaluate this "pending-review" properly, and don't
throw it away without joining this discussion. There are too
many "pending-review" leaves already which were never
looked at properly.
Regards,
Jan Nijtmans
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
