Dear Fossils ;-) I have been using Fossil for about a year, now, and discovering Fossil lines up among the most exciting moments of my hobbyist computing career, such as playing the DOOM shareware version the first time (ok, the first 1000 times), installing the brand-new Windows 95, or waiting 3 weeks for the shipment of my Visual C++ 4.2 package back in 1997. Fossil is so simple and clean to use, yet massively increases my hobbyist "productivity" and fun, I just have to say THANKS!
I really like the recently added color graph lines (rails) in the timeline view of the web interface, as I'm often using custom branch colors to distinguish the states of branches. I have noted some minor glitches I would like to report here: The bg_to_fg() function in src/timeline.c does not recognize custom branch colors noted in the shorthand form (i.e. #feb instead of #ffeebb) and so returns the original color, instead of a darker (or, if a white foreground is in use, lighter) variant, so in the case of #feb, the timeline rails are hardly visible. I would like to suggest that 4-char color strings starting with '#' are evaluated to hex_digit_value()*17 for each of the RGB components in bg_to_fg(), by analogy with 7-char strings starting with '#'. Also, I noted that for some colors, such as #ffc000, the rail color is set to #8041ffff, which is not a valid HTML color, and therefore results in fallback display with black color (at least, with Chromium). I'd like to suggest that bg_to_fg() ensures each of the x[0-2] color components is between 0 and 255, before feeding them to sqlite3_snprintf(), which would result in the more suitable rail color #804100 for branch color #ffc000. I'd be happy if these small adaptations could be made. However I'm not sure if there's a policy to require branch colors to fit the #xxxxxx format, so that values like #feb (and also 'gold') are invalid in the first place, and whether hash_color() may always return colors that bg_to_fg() is able to handle without over/underflows, so that using custom branch colors outside the "moderate hash_color() range" is generally not advised. Best wishes --Florian _______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
