On 7. 2. 2016 15:24, Jan Nijtmans wrote: > 2016-02-07 14:12 GMT+01:00 David Macek: >> Hmm. So hopefully he's watching the list. > > Yes, I am watching this list. I always build fossil using > win/Makefile.mingw or win/Makefile.mingw.mistachkin, > they work fine in the combinations I normally use. My (64-bit > mingw-w64) build can be found here: > <http://sourceforge.net/projects/cyqlite/files/fossil/>
I use configure+make. Maybe that's the reason for the things I see. >> One of my problems is with the linenoise library. It requires <termios.h> >> and possibly other POSIX-only stuff. Is there a way to override it to use >> editline/readline? > > I didn't try to enable lineoise, I just was assuming it wouldn't work on > win32. Me neither, it just tried to compile. See above. >> Slightly off-topic: Is there a chance that some of the `#if defined(_WIN32) >> || defined(__CYGWIN__)` stuff can be put under an additional condition? I >> disable a bunch of these using a patch, but using a define instead would be >> nicer. > > Well, I'm interested in your patch, and the reason for disabling those > parts. I'm not aware of any trouble those sections might cause, but > I'm aware of the trouble that might be caused by leaving them out ;-) Current patch here: https://github.com/elieux/MINGW-packages/blob/ec40fa2f7fcd1f4958b48c7870a4de7dfb52d708/mingw-w64-fossil/win.patch The reason is to reduce unexpected behavior. In MSYS2, we want to build software as close as reasonably possible to Linux "originals". I can see that the WIN32/CYGWIN stuff is there for a reason, but it's more suited for Fossil as a stand-alone app on otherwise graphical Windows. >> Is FOSSIL_ENABLE_MINIZ in Makefile used at all? I get `FOSSIL_ENABLE_MINIZ = >> @FOSSIL_ENABLE_MINIZ@` in my Makefile. > > I don't think using miniz gives any advantage, linking in zlib > statically is what I always do. I wasn't planning on using miniz. I'm asking why it's not substituted from Makefile.in into Makefile. See above. >> Is BROKEN_MINGW_CMDLINE supposed to be defined on mingw-w64? It seems to >> build and work regardless (both globbing and non-ASCII characters in >> filenames), but maybe I'm missing something. > > BROKEN_MINGW_CMDLINE is meant for the original mingw only, for > mingw-w64 everything's fine. For details, see: > <http://sourceforge.net/p/mingw/bugs/771/> I tried it just now with v1.34 and I need to explicitly define it, otherwise the build breaks with `undefined reference to `WinMain'` because of the main/wmain change. It seems that in trunk, it gets defined automatically now. -- David Macek
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
