On 3/7/2016 12:39 PM, Joe Mistachkin wrote:
Ross Berteig wrote:
I don't think that is needed any more?
$ fossil open ../fossil.fossil
$ ./configure --with-miniz --with-openssl=none
....
$ make test"
....
In an open checkout: cannot initialize a new repository here.
while executing
"error "In an open checkout: cannot initialize a new repository here.""
I missed a detail in that run. Turned out that I was building from tip
of trunk, not the testerCleanup branch. But the same issue applies.
Currently, this behavior can be disabled by setting the environment
variable "FOSSIL_TEST_DANGEROUS_IGNORE_OPEN_CHECKOUT" to "YES_DO_IT".
I'm still not 100% sure we want to disable this checking by default,
although I might be convinced otherwise.
I ran "make test" with that environment variable set, with the above
recipe tweaked by inserting "fossil update testerCleanup" before running
configure. I checked "fossil timeline" and "fossil changes" before and
after to make sure that no case actually modified the repository.
After the run, "fossil timeline", "fossil changes", and the filesystem
time stamps on the repository and local _FOSSIL_ databases all agree
that no test case wrote to the repository or to the checkout.
I can confirm that without setting the environment, "make test" in an
external build directory works as expected.
I think that if the Makefile is going provide a "test" target, then it
should be usable in the obvious case of "./configure; make; make test".
Otherwise, something (configure?) should be enforcing the rule that
building be out of tree.
Building out of tree is certainly sensible, and anyone building more
than one configuration (especially anyone cross compiling) will want to
do that. But it is unneeded friction for someone who just wants a copy
of fossil with a tweaked configuration, and they should still be able to
run the test harness for confidence if desired.
--
Ross Berteig r...@cheshireeng.com
Cheshire Engineering Corp. http://www.CheshireEng.com/
+1 626 303 1602
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
