On Mon, Nov 27, 2017 at 7:00 AM, <fossil-users-requ...@lists.fossil-scm.org> wrote: > > Date: Mon, 27 Nov 2017 09:50:29 +0000 > From: Javier Guerra Giraldez <jav...@guerrag.com> > Subject: Re: [fossil-users] Trolling GitHub for ideas > > the only github think i've really missed when using fossil for > non-personal projects is the ability to comment on a diff. >
This would be a very handy feature to have. I think it could be implemented by adding Javascript to the existing diff output. Maybe save the comments in a wiki page with a name derived from the filename and commit ID, appending each comment to the page. The Javascript code would get the line numbers of the from and to versions of the file from the diff output. Actually, I'd rather the comments be saved in a ticket. I think a tag on the commit could be used to identify the ticket. All comments would go in 1 ticket, regardless of the file. I'm not sure how the Javascript could find the filename. Maybe the diff output would need to have anchors inserted by Fossil's diff generator. As a bonus, Fossil's ticket artifacts are designed to support appending to ticket fields. The diff comments will be stored without duplicating all previous diff comments when a new one is posted. FWIW, since my group at work was already using Review Board (reviewboard.org) with SVN, when I introduced Fossil, our Python geek butchered RB's CVS support to (sort of) support Fossil. (We enter review requests with "fossil diff | rbt post --diff-filename=-" ) Unfortunately, that person left the company and our IT department won't let us access RB's Python files on that server, so I can't share the changes that were made. (Personally, I don't like Review Board. Also, since we only use RB for commenting on diffs, adding diff comments to Fossil would allow us to keep everything in Fossil (and to stop using RB).)
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
