On 02.01.14 14:35, Jonas Maebe wrote: > > On 02 Jan 2014, at 14:11, Nico Erfurth wrote: > >> I've added a new CPU-feature flag CPUARM_HAS_UMULL and also used it for >> the 64x64=>64bit code. > > I think it would be cleaner to also use it in > tarmaddnode.use_generic_mul32to64 (maybe it's also necessary for > correctness, since in pass_1 you check is_64bitint(left.resultdef) in > tarmaddnode.pass_1 and that will return false if use_generic_mul32to64 > returned true, which it currently always does).
You're right and Florian already fixed it. I'll have to work on my arm testsetup for the different architectures and ISAs to catch stuff like this BEFORE i'm committing. ;) Nico _______________________________________________ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel
