On 19/10/2022 22:56, Martin Frb via fpc-devel wrote:
On 19/10/2022 21:12, Pierre Muller via fpc-devel wrote:
Hi Martin,
could you tell me if
https://gitlab.com/freepascal.org/fpc/source/-/issues/39928#note_1140122898
fixes your troubles?
Thanks in advance,
It looks like the right direction. But see my comment on the issue.
It is correct as in that those are the 2 values that need to be
adjusted (According to code review). Just the 2nd case should be
adjusted by assigning the correct values to the variable "uppercodes"
I will have to setup a quick test.
I had my findings by code-review only.
Ok, I made a merge request (slightly diff from the patch, but to the
same effect).
I tested this, and it produces valid dwarf again.
There is the question as to introducing a constant, instead of changing
several copies of the same number.
On the other hand it happens once every x years.
And I don't know what the preferred style is.
Could also be
const EntryLen = array[Boolean] of integer = (14, 17);
and then use a boolean variable instead of "uppercodes".
But that is not part of the issue itself.
_______________________________________________
fpc-devel maillist - fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
