On Mon, 4 Feb 2013, Reinier Olislagers wrote:
Hi list, In sqldb bufdataset.pas, going through the code looking through the comments, this code caught my eye (around line 1164): procedure TCustomBufDataset.InternalOpen; ... // parse filter expression try ParseFilter(Filter); except // oops, a problem with parsing, clear filter for now on E: Exception do Filter := EmptyStr; end; seems to swallow problems with parsing filter expressions. Shouldn't the exception bubble up though so the user is notified? If the filter is not correct, e.g. showing all data instead of what the user wanted seems a bit weird..
I think it should indeed bubble up. Michael. _______________________________________________ fpc-pascal maillist - [email protected] http://lists.freepascal.org/mailman/listinfo/fpc-pascal
