Hi Timo,
> Though, the problem is the state mapping when the workflow changes (see
types-controlpanel-workflow screenshot attached). I think the workflow
setting in the discussion control panel can either:
> 1) change the workflow ignoring the option for custom mappings.
> 2) or I have to implement a widget similar to the one in the types
control panel
I really don't think it's necessary. Basically, the two cases are:
1) User was using moderation and switching to single state. So in this case
the mapping is automatically published so the user doesn't need to think
about it.
2) User was using single state and switching to moderated commenting. All
the previous comments were published anyways, so just map them to published
again for the user. If the user is advanced enough, they can do it manually
in the types control panel.
I agree with everything else you've done. It looks good!
-Nathan
On Fri, Dec 10, 2010 at 3:57 AM, Timo Stollenwerk <li...@zmag.de> wrote:
> Hi Nathan,
>
> thanks for your review!
>
> Am 08.12.2010 15:17, schrieb Nathan Van Gheem:
> > Hi Timo,
> >
> > > PLIP REVIEW: Moderating comments by changing the workflow is gross.
> I
> >
> > > think it's work the extra effort here to add a moderate comments
> >
> > > checkbox to the add on configuration.
> >
> > >
> >
> > > QUESTION: In order to activate the moderation workflow for
> > comments, the
> >
> > > user has to go to the types control panel, choose the "comment
> review
> >
> > > workflow" for the "comment" type. Is it ok to just add a checkbox
> > in the
> >
> > > discussion control panel to enable the comment review workflow for
> >
> > > comments? In general, is it ok to duplicate configuration options
> in
> >
> > > Plone control panels?
> >
> > Yes. I think this is the best way to go. It's just an implementation
> > detail that
> > moderation is enabled by applying a workflow--I don't think
> users(especially
> > novice ones) should be expected to know that.
>
> It should be pretty straight forward to add an additional
> checkbox/select field to the discussion control panel in order to allow
> users to switch between the different comment workflows ('one state' and
> 'review').
>
> Though, the problem is the state mapping when the workflow changes (see
> types-controlpanel-workflow screenshot attached). I think the workflow
> setting in the discussion control panel can either:
>
> 1) change the workflow ignoring the option for custom mappings.
>
> 2) or I have to implement a widget similar to the one in the types
> control panel
>
> My current idea is to go with 1) and use a single checkbox to enable
> comment moderation (see pad-controlpanel-comment-moderation.png
> screenshot attached). If selected, the moderation workflow is enabled,
> if not the single state workflow is enabled.
>
> If a custom workflow is enabled, the checkbox is disabled (see the last
> two setting on the controlpanel screenshot for an example) and an info
> message shows up telling the user to go to the types control panel to
> change this setting.
>
> This will allow users without custom workflows to easily enable/disable
> comment moderation and allow advanced users to change the setting to
> custom workflows in the types control panel.
>
> What do you think?
>
> Cheers,
> timo
>
>
> _______________________________________________
> UI mailing list
> u...@lists.plone.org
> http://lists.plone.org/mailman/listinfo/ui
>
>
_______________________________________________
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team
