On Mon, Nov 15, 1999 at 05:59:23PM -0800, Kris Kennaway wrote:
> On Tue, 16 Nov 1999, Pierre Beyssac wrote:
> > I've checked, the answer is no: apparently, in_cksum() in routed/rdisc.c
> > is only called in two places, both with an even size.
>
> Can it hurt to pre-emptively fix it anyway in case some future change
> pulls the rug out from underneath?
We could, but since the danger is purely theoretical for now (and
probably will stay that way forever), I don't see any advantage in
cluttering up the code. Since routed is sometimes sync'ed from
external sources, it would only make life harder for the people
doing the merges.
Plus, everyone steals in_cksum from ping, not from routed (at least,
that's what I do :-)
Since in_cksum is used in several places (there's another optimized
copy in libstand), a cleaner solution would be to put it in some
library.
--
Pierre Beyssac [EMAIL PROTECTED]
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
