On Fri, 19 Feb 1999, Matthew Dillon wrote: > This may or may not be related. In tracking down the sched_sync() > panic I found two bugs. > > First, a couple of places where the worklist was not being protected > at splbio(). I'm not 100% sure that this is a problem but the code > is complex enough that it's just too dangerous not to do it. > > Second, a double LIST_REMOVE() was being performed in the case where > VOP_FSYNC() would fail to sync all the dirty pages. This can occur > legally for both NFS and filesystems with SOFTUPDATES set. > > I'd appreciate it if someone could verify the double LIST_REMOVE() > bug. vn_syncer_add_to_worklist() already removes the vn from > the list ( assuming the VONWORKLIST v_flag is set, which it should be > in this case ).
Your fixes for both problems look fine to me. -- Doug Rabson Mail: d...@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
