On 01/14/12 15:48, Alexander Best wrote:
On Thu Jan 12 12, Rainer Hurling wrote:
On 12.01.2012 12:18 (UTC+1), Alexander Motin wrote:
On 01/12/12 12:52, Gary Jennejohn wrote:
On Wed, 11 Jan 2012 21:33:17 +0200
Alexander Motin<m...@freebsd.org> wrote:
I would like request for testing of my work on further HDA sound driver
improvement.
[big snip]
Patch can be found here:
http://people.freebsd.org/~mav/hda.rewrite.patch
Patch was generated for 10-CURRENT, but should apply to fresh 9-STABLE
and 8-STABLE branches also.
The patch doesn't apply cleanly to r230008; hdac.c.rej is 15661 bytes
in size (mostly the section which deletes all the manufacturer-specific
defines at the top of the file).
That is probably because of $FreeBSD$ macro resolution. Here is version
with present value from 10-CURRENT SVN (sources from CVS or STABLE will
need that patch line modified respectively) and some minor additional
improvements like CODEC ODs and some more sysctls:
http://people.freebsd.org/~mav/hda.rewrite2.patch
maybe you could try silencencing these clang warnings?
/usr/subversion-src/sys/dev/sound/pci/hda/hdaa.c:5707:25: warning: format
string is not a string literal (potentially insecure) [-Wformat-security]
snprintf(buf, buflen, chans = "4.0");
^~~~~~~~~~~~~
/usr/subversion-src/sys/dev/sound/pci/hda/hdaa.c:5709:25: warning: format
string is not a string literal (potentially insecure) [-Wformat-security]
snprintf(buf, buflen, chans = "5.1");
^~~~~~~~~~~~~
/usr/subversion-src/sys/dev/sound/pci/hda/hdaa.c:5711:25: warning: format
string is not a string literal (potentially insecure) [-Wformat-security]
snprintf(buf, buflen, chans = "7.1");
^~~~~~~~~~~~~~
/usr/subversion-src/sys/dev/sound/pci/hda/hdacc.c:563:52: warning: if statement
has empty body [-Wempty-body]
if ((child = codec->streams[dir][stream]) != NULL);
^
4 warning generated.
..i'll report how the changes interact with my system later on.
Thank you! That variable is not even used now, so I'll just remove that
assignment. I've passed the code through the clang static analyzer at
some point, but probably I've introduced that later.
--
Alexander Motin
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
