gperf has some clang warnings that seem to be harmless, but annoying regarding some of the logical operations around detecting ascii chars:
c++ -O2 -pipe -I/usr/obj/usr/src/tmp/legacy/usr/include -Wno-c ++11-extensions -I/usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/lib -I/usr/src/gnu/usr.bin/g perf -c /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/options.cc /usr/src/gnu/usr.bin/gperf/../../../contrib/gperf/src/options.cc:284:27: warning: '&&' within '||' [-Wlogical-op-parentheses] if (*arg >= 'A' && *arg <= 'Z' || *arg >= 'a' && *arg <= 'z') ~~~~~~~~~~~~^~~~~~~~~~~~~~ ~~ I propose the following change: Index: options.cc =================================================================== --- options.cc (revision 256712) +++ options.cc (working copy) @@ -281,7 +281,7 @@ { putchar (*arg); arg++; - if (*arg >= 'A' && *arg <= 'Z' || *arg >= 'a' && *arg <= 'z') + if ( (*arg >= 'A' && *arg <= 'Z') || (*arg >= 'a' && *arg <= 'z') ) { putchar (*arg); arg++; @@ -293,7 +293,9 @@ putchar (*arg); arg++; } - while (*arg >= 'A' && *arg <= 'Z' || *arg >= 'a' && *arg <= 'z' || *arg == '-'); + while ( (*arg >= 'A' && *arg <= 'Z') || + (*arg >= 'a' && *arg <= 'z') || + (*arg == '-') ); if (*arg == '=') { putchar (*arg);
signature.asc
Description: This is a digitally signed message part