On May 30, 2015, at 19:15, Craig Rodrigues <rodr...@freebsd.org> wrote:
> On Thu, May 28, 2015 at 9:49 AM, Konstantin Belousov <kostik...@gmail.com> > wrote: > >> On Wed, May 27, 2015 at 11:30:45PM -0700, Craig Rodrigues wrote: >> >> I take some time to do a pass over mine code or code I am somewhat >> knowledgable, to correct some 'assigned but not used variable' warnings. >> There might be even one real bug in SU code uncovered, but I am not >> sure yet. >> >> Please review at https://reviews.freebsd.org/D2665 . >> I do not have an intention of splitting this into individual changes. >> > > Thanks for committing these fixes. > Jenkins detected this as fixing 42 warnings: > > https://jenkins.freebsd.org/job/FreeBSD_HEAD_amd64_gcc4.9/34/warnings17Result/ > > Every little bit helps! The -Wstrict-aliasing warnings are particularly useful, considering clang still doesn’t support this detection… Thanks :)! -NGie
signature.asc
Description: Message signed with OpenPGP using GPGMail