* Dmitry Chagin <dcha...@freebsd.org> [20230904 21:49]: > On Mon, Sep 04, 2023 at 08:43:02PM +0200, Felix Palmen wrote: > > Thanks a lot for the quick patch! I have to admit I don't fully > > understand it immediately, but I assume it's an attempt to only list > > attributes not in system.* when that namespace is restricted? > > no, > + if (error == EPERM) > + break; > mean that listxattr will fail if user is unauthorized to access system > namespace, ie, listxattr will return ENOTSUP
Ah, now I get it, so breaking out of the loop there will leave attrnamespace at EXTATTR_NAMESPACE_SYSTEM if that was the cause, therefore error_to_xattrerror() works as expected. Nice! Well, given that I really don't expect any further problems, but give my poor builder a few hours to *really* verify :) Cheers, Felix -- Felix Palmen <zir...@freebsd.org> {private} fe...@palmen-it.de -- ports committer -- {web} http://palmen-it.de {pgp public key} http://palmen-it.de/pub.txt {pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231
signature.asc
Description: PGP signature