> On 21. Mar 2024, at 18:12, Dimitry Andric <d...@freebsd.org> wrote:
>
> On 21 Mar 2024, at 01:12, tue...@freebsd.org wrote:
>>
>>> On 21. Mar 2024, at 00:27, Dimitry Andric <d...@freebsd.org> wrote:
>>>
>>> On 20 Mar 2024, at 21:44, tue...@freebsd.org wrote:
>>>>
>>>> I'm trying to run make buildworld / make installworld on a recent main
>>>> branch
>>>> (some days old).
>>>>
>>>> The problem is related to lib/libc/tests/ssp/Makefile
>>>> which contains:
>>>> _libclang_rt_ubsan=
>>>> ${SYSROOT}${SANITIZER_LIBDIR}/libclang_rt.ubsan_standalone-${CRTARCH}.a
>>>> if exists(${_libclang_rt_ubsan})
>>>> PROGS+= h_raw
>>>> LDADD.h_raw+= ${SANITIZER_LDFLAGS}
>>>>
>>>> When running make buildworld, we have
>>>> ${SYSROOT} = /usr/obj/usr/home/tuexen/freebsd-src/powerpc.powerpc64/tmp
>>>> ${SANITIZER_LIBDIR} = /usr/lib/clang/17/lib/freebsd
>>>> and so the script is looking for
>>>> /usr/obj/usr/home/tuexen/freebsd-src/powerpc.powerpc64/tmp/usr/lib/clang/17/lib/freebsd/libclang_rt.ubsan_standalone-powerpc64.a
>>>> which does not exist:
>>>> tuexen@blackbird:~ % ls -l
>>>> /usr/obj/usr/home/tuexen/freebsd-src/powerpc.powerpc64/tmp/usr/lib/clang/17/lib/freebsd/
>>>> total 652
>>>> -r--r--r-- 1 root wheel 284316 Mar 20 18:03 libclang_rt.profile-powerpc.a
>>>> -r--r--r-- 1 root wheel 380704 Mar 20 17:41
>>>> libclang_rt.profile-powerpc64.a
>>>>
>>>> Therefore, h_raw to NOT built.
>>>
>>> As far as I can see, for powerpc64 it should have been built somewhere
>>> during the libraries stage. So it's a bit strange that you don't have the
>>> file. Did you use any special options to build?
>> No, not any I'm aware of. I can run tests or provide further information.
>
> This was my mistake: I recently refactored lib/libclang_rt/Makefile to make
> it more readable and maintainable, but it accidentally broke building of most
> of the libclang_rt*.a files for powerpc64. It should now be fixed by
> https://cgit.freebsd.org/src/commit/?id=f0620ceeccf0 .
Hi Dimitry,
I tested the main branch with your fix and I can confirm that the
problem is fixed.
Thank you very much for the quick fix!
Best regards
Michael
>
> -Dimitry
>
