On Sun, 25 Aug 2002, David O'Brien wrote:

> On Sun, Aug 25, 2002 at 12:43:44PM -0400, Mike Barcroft wrote:
> > Craig Rodrigues <[EMAIL PROTECTED]> writes:
> > > device.hints.5:
> > >      $FreeBSD: src/share/man/man5/device.hints.5,v 1.3 2002/08/09 06:07:33 
>obrien Exp $
> > > I would like to submit the following trivial patch:
> > >
> > >
> > > --- device.hints.5.orig   Sun Aug 25 12:52:02 2002
> > > +++ device.hints.5        Sun Aug 25 12:52:26 2002
> > > @@ -145,7 +145,7 @@
> > >
> > >  The following example disables the ACPI driver
> > >  .Bd -literal -offset indent
> > > -hint.acpi.0.disable="1"
> > > +hint.acpi.0.disabled="1"
> > >  .Ed
> > >  .\" .Pp
> > >  .\" A control variable may look like:
> >
> >
> > Committed, thanks.
>
> Uh WAIT!  Was this tested?!?
> $ grep disable /sys/boot/i386/libi386/i386_module.c
>     if ((getenv("acpi_load") && !getenv("hint.acpi.0.disable"))) {
>
> "hint.acpi.0.disable=1" certainly did not load the acpi.ko module for me
> (as expected by inspecting the code).  I'm backing this commit out
> someone can prove it is proper.

It seems to be proper for disabling acpi itself (see dev/acpica/acpi.c)
but not its loading.  So to fully disable acpica, you have to do something
like:

    hint.acpi.0.disable="I prefer not to use code that (mis)uses !getenv()"
    hint.acpi.0.disabled="1"

Bruce


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to