On Fri, Oct 25, 2002 at 05:34:15PM -0700, Bakul Shah wrote: > > Here's a new patch that gives the user more of a hint at how to add PPP > > support and only loads the module if they are actully root. How's this > > look? > > I still don't like it. How to explain.... > > I don't think it is pppd's responsibility to muck with > modules. It is like mount kldloading a disk driver module. > Neither program has any business guessing which module name > goes with which device/feature. > > What if I want to run ppp over ethernet over atm? I know you > can't do this today but in general the trend should be to > make protocol modules more flexible not less. Hardwiring > module names is analogous to making a function non-reentrant.
This isn't going to have an effect on the ability to use kernel ppp for other things. The tty orientation of pppd and the outdated, unmodular design on ppp(4) have taken care of that. This patch gives people the functionality they want (pppd just working) without any major entanglements (the whole function is <20 lines). If someone wants to make pppd work on arbitrary devices we can deal with that when it happens and I frankly doubt it's ever going to since we've got netgraph to do that with. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
msg45353/pgp00000.pgp
Description: PGP signature
