On Fri, 3 Jan 2003 [EMAIL PROTECTED] wrote: > In message <[EMAIL PROTECTED]>, Takahashi Yoshihiro > writes: > >In article <[EMAIL PROTECTED]> > >Poul-Henning Kamp <[EMAIL PROTECTED]> writes: > > > >> I think you need to either #ifdef something here (and there may be > >> more some similar code in places like truss or the debugger) or > >> alternatively rename the structure to "pc98_partition" or similar. > > > >I think that the name "dos_partition" is not suitable for both i386 > >and pc98. I wonder what does "dos" mean here. For example, it should > >be renamed to "mbr_partition" for i386 and "pc98_partition" for pc98, > >respectively. > > You are correct in principle.
"pc98_partition" is OK, but "mbr_partition" is bogus since partition tables are not restricted to the MBR -- there is one in every extended partition. <sys/diskpc98.h> is similarly OK and <sys/diskmbr.h> is similarly bogus. "at386" would be a better prefix/suffix than "mbr" for the non-pc98 pc's. It is used for the main bus space header. The normal prefix for "partition table" seems to be "" according to google. FreeBSD has "dos_partition" and NetBSD has "mbr_partition". Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message