Re: VM_METER no longer defined?

[Scott Long]

Craig Rodrigues wrote:

On Fri, Jan 17, 2003 at 10:26:10AM -0800, Will Andrews wrote:

>Of course, these things can be fixed.  But I consider this change
>gratuitous and it breaks standard compatability rules: deprecate
>for one major version and remove in the second.  I haven't seen
>any reason why this couldn't be added to vm/vm_param.h:
>
>#define VM_METER VM_TOTAL
>
>for compatability purposes.  This change is way too sudden in an
>external API (if it's supposed to be internal, then protect it
>with an #ifdef _KERNEL already!).


How about this then:


Index: vm_param.h
===================================================================
RCS file: /home/ncvs/src/sys/vm/vm_param.h,v
retrieving revision 1.16
diff -u -r1.16 vm_param.h
--- vm_param.h	2003/01/11 07:29:46	1.16
+++ vm_param.h	2003/01/17 23:25:52
@@ -89,6 +89,8 @@
 #define VM_SWAPPING_ENABLED	11	/* swapping enabled */
 #define	VM_MAXID		12	/* number of valid vm ids */

+#define VM_METER	VM_TOTAL /* backwards compatibility, struct vmmeter */
+
 #define CTL_VM_NAMES { \
 	{ 0, 0 }, \
 	{ "vmtotal", CTLTYPE_STRUCT }, \





The only place where VM_METER is used in this directory was in vm_meter.c:

    240 SYSCTL_PROC(_vm, VM_METER, vmmeter, CTLTYPE_OPAQUE|CTLFLAG_RD,
    241     0, sizeof(struct vmtotal), vmtotal, "S,vmtotal",
    242     "System virtual memory statistics");

This changed to:

    240 SYSCTL_PROC(_vm, VM_TOTAL, vmtotal, CTLTYPE_OPAQUE|CTLFLAG_RD,
    241     0, sizeof(struct vmtotal), vmtotal, "S,vmtotal",
    242     "System virtual memory statistics");

This is ugly and only further perpetuates what appears to be a gratuitous API
change. Let's wait to hear from the submitter (Hiten) and committer (Matt) to
see why this was needed in the first place.

Hiten? Matt?

Scott


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message