Craig Rodrigues wrote: > On Tue, Jan 28, 2003 at 07:04:07PM -0600, Sean Kelly wrote: > > I just noticed this during bootup. It is repeatable. > > See: > http://news.gw.com/freebsd.current/30547
That's a "turn your head and cough" patch. It admits the code is broken, and leaves it broken. It also leaves the p->p_fd dereference for assignment unprotected, where at least with the reversal, it's protected. Probably the correct thing to do is to move the assignment out of the "if" statement, and then put a reference counter on the fdp, which, so long as you are not the sole reference, you are not allowed to delete it (similar to VREF in SVR4/Solaris). -- Terry To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
