Hiten Pandya wrote: > Hello everyone. This not something major, but I recently experienced > panics in some of my old QNX4 filesystem porting code, and an old 5.0 > kernel with UNIONFS problems. > > The kernel will panic if vfs_get/copyopt() was passed 'opts' as NULL. > It would be good to add KASSERT's to these calls. I have passed this > patch around on IRC, and have not seen any objections.
Why the need for a KASSERT() when we will panic() anyway if NULL is passed ? There's no need for manually calling panic() when the code will end doing so, and I specifically did not put KASSERT() there for this reason. Cheers, Maxime To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
