On Sat, Mar 08, 2003 at 11:19:43AM -0500, Craig Rodrigues wrote:
> Hi,
> 
> In <sys/syslimits.h>, I see:
> 
> #if __GNUC__
> #warning "No user-serviceable parts inside."
> #endif
> 
> 
> Does the use of #warning need to be protected by
> #if __GNUC__ in FreeBSD header files?  I am working
> on something similar for <machine/limits.h>.

I think the use of #warning should be protected against abuse :-)

In general I probably would opt to not protect it with #if __GNUC__
because #warning is not specific to gcc and since we're only compiling
with gcc (officially) it's better to have it fail when somebody does
use a different compiler. I think the discussion that it will trigger
will yield a less gratuitous convention. Possibly documented. YMMV.

-- 
 Marcel Moolenaar         USPA: A-39004          [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to