On Thu, Jun 12, 2003 at 07:18:12AM +0200, Wiktor Niesiobedzki wrote: > On Wed, Jun 11, 2003 at 09:50:22PM -0700, Kris Kennaway wrote: > > On Wed, Jun 11, 2003 at 10:48:32PM -0600, Andrew Lankford wrote: > > > >Can you try backing out bsd.sys.mk to r1.26 and rebuild your world and > > > >kernel? Later versions of this file are causing strange problems >with > > > >package builds. > > > > > > I was a little lazy and just backed out bsd.sys.mk to 1.26 as you > > > suggested, rebuilt /usr/lib/ , /usr/include/, and ppp. My kernel is the > > > same as last time. As a result, ppp's now up and running again. > > > > Thanks, that's actually more useful because it isolates the problem. > > It's probably something in ppp that is misbehaving with CSTD=c99. > > > alloca(3) function is misbehaving in ppp (namely ether.c). Is this a compiler > bug?
Okay, it looks like alloca.S was broken. My previous patch that
increased the size of allocations was just a gratuitous difference
with the inline version, and is not necessary. Here's a fix that
seems to get ppp to stop complaining.
Kris
Index: alloca.S
===================================================================
RCS file: /usr/home/ncvs/src/lib/libc/i386/gen/alloca.S,v
retrieving revision 1.10
diff -u -r1.10 alloca.S
--- alloca.S 23 Mar 2002 02:44:18 -0000 1.10
+++ alloca.S 12 Jun 2003 07:35:03 -0000
@@ -51,6 +51,7 @@
andl $0xfffffffc,%eax
subl %eax,%esp
movl %esp,%eax /* base of newly allocated space */
+ leal 24(%esp), %eax
pushl 8(%ecx) /* copy possible saved registers */
pushl 4(%ecx)
pushl 0(%ecx)
pgp00000.pgp
Description: PGP signature
