On Mon, Mar 15, 2010 at 08:44:26AM -0600, M. Warner Losh wrote: > In message: <20100315142806.ga5...@dragon.nuxi.org> > "David O'Brien" <obr...@freebsd.org> writes: > : On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote: > : > In message: <20100312171206.ga31...@dragon.nuxi.org> > : > "David O'Brien" <obr...@freebsd.org> writes: > : > : * Simplify SRCDIR calculation by directly finding the kernel sources > : > : based directly on one of them. > : > : Reviewed by: dhw > : > : This change does not increase the kernel build time. It also > continues > : > : to restrict the revision to just the kernel sources, and not the whole > : > : tree. > : > : Timing tests by: dhw > : > > : > <patch omitted> > : > > : > I have a better simplification, I think, that works for me for each of > : > the tests that I've done (both traditional and buildkernel builds). > : > : I also have other simplifications. But want to do this in stages, > : least there be some corner case or misunderstanding by someone. > > Normally this is a sensible process. However, my patches change how > we guess where sys is, and as such, I think we should go directly > there and work out the corner cases and such there.
Well that's what I was trying to do with the patch I sent you in Message-ID: <20100308010125.ga6...@dragon.nuxi.org> on 7-March-2010. There you didn't care for that approach and would not give details as to the claims you made. I will reply in another email the issues with your patch. > : I would prefer to do this in stages so things aren't misunderstood. > : This patch is one of the key parts that shows I am not making the > : 'svnversion' run take longer, and that it does not cover more of > : the tree than before. > > That's exactly what my patch does by passing in SYSDIR directly. Why > guess and then replace it with a different guess. Guess??? 'newvers.sh' is not going to be within the kernel sources tree?? Are you allowing for the person that did a 'mv sys/conf/newvers.sh' to elsewhere? Considering you have "sh $S/conf/newvers.sh", I don't see where you are. Is "$0" confusing you? -- -- David (obr...@freebsd.org) _______________________________________________ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
