https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285426
--- Comment #15 from Gleb Popov <[email protected]> --- (In reply to Daniel Engberg from comment #14) This brings us to the question "Should we disable failing tests to let others run and testing to succeed?" My answer to that is "no". I view a port as a sort of adapter or wrapper construct around the upstream project. If the upstream project insists on running X tests and expect all of them to pass, then the same expectation should be set by the port. Selectively disabling tests to make "make test" look green may create a false feeling that the software runs correctly. But I agree that we don't have any rules regarding this in Porters Handbook, so you can do as you wish. However, if you go this route, I'd recommend to remove patch-test_run-test.sh and instead just do ${RM} "$BUILDTESTDIR"/test-crbug1004254 somewhere in post-extract or post-patch. This will effectively disable the test. -- You are receiving this mail because: You are the assignee for the bug.
