Re: Fix the restart button

[Graham Perrin]

On 16/06/2022 08:29, Baptiste Daroussin wrote:

Hello,

I have stolen this patch from OpenBSD, which was done to please pledge, but in
the end fixes the restart button.

https://bapt.nours.eu/patch-xpcom_build_BinaryPath.h

If my investigation is right, firefox when one click on the restart button (in
case of upgrade) will call for the sysctl KERN_PROC_PATHNAME, which will return
en empty value, because the binary has been unlinked and replace by the new one.
(the behaviour is different on linux here) but forcing the path at buildtime
make it work reliably and at least here, it makes the restart button working
reliably

note that it needs a post-patch target to replace %%PREFIX%% in
xpcom/build/BinaryPath.h file.

Best regards,
Bapt

Hi

With Firefox 112.0.1_1,2, I can not find a restart button in toolbar customisation preferences. Is the patch intended to make visible and/or functional a button that already exists in Firefox? Or intended to add a button, a feature request?

OpenPGP_signature
Description: OpenPGP digital signature