On Thu, Jul 02, 2015 at 03:01:09PM -0500, Matthew D. Fuller wrote: > On Thu, Jul 02, 2015 at 11:49:10AM +0200 I heard the voice of > Pawel Jakub Dawidek, and lo! it spake thus: > > > > With g_media_changed() we can get spoil event even if we hold > > provider exclusively open. Your patch, Matthew, is correct, but > > could you also update the comment there to take into account > > g_media_changed() addition? > > Sure, you mean replacing the comment saying spoiling can't happen? > Something like: > > Index: g_eli.c > =================================================================== > --- g_eli.c (revision 285057) > +++ g_eli.c (working copy) > @@ -730,10 +730,10 @@ > sc = malloc(sizeof(*sc), M_ELI, M_WAITOK | M_ZERO); > gp->start = g_eli_start; > /* > - * Spoiling cannot happen actually, because we keep provider open for > - * writing all the time or provider is read-only. > + * Spoiling can happen even though we have the provider open > + * exclusively, e.g. through media change events. > */ > - gp->spoiled = g_eli_orphan_spoil_assert; > + gp->spoiled = g_eli_orphan; > gp->orphan = g_eli_orphan; > gp->dumpconf = g_eli_dumpconf; > /*
Committed, thanks! -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com
pgpuZKEZYPoHA.pgp
Description: PGP signature
