Andriy Gapon <a...@freebsd.org> wrote:
> on 12/07/2012 22:36 Fabian Keil said the following:
> > Andriy Gapon <a...@freebsd.org> wrote:
> >
> >> on 12/07/2012 21:17 Fabian Keil said the following:
> >>> Benjamin Kaduk <ka...@mit.edu> wrote:
> >>>
> >>>> On Wed, 11 Jul 2012, Fabian Keil wrote:
> >>>>
> >>>>> I'm using the following modification of Sean's patch:
> >>>
> >>> This way it seems to work as expected:
> >>>
> >>> diff --git a/sys/modules/dtrace/dtraceall/Makefile
> >>> b/sys/modules/dtrace/dtraceall/Makefile index 456efd1..628583b 100644
> >>> --- a/sys/modules/dtrace/dtraceall/Makefile +++
> >>> b/sys/modules/dtrace/dtraceall/Makefile @@ -1,7 +1,7 @@ # $FreeBSD:
> >>> src/sys/modules/dtrace/dtraceall/Makefile,v 1.3 2011/04/09 09:07:31 uqs
> >>> Exp $
> >>>
> >>> KMOD= dtraceall -SRCS= dtraceall.c opt_compat.h
> >>> +SRCS= dtraceall.c opt_compat.h opt_nfs.h
> >>>
> >>> CFLAGS+= -I${.CURDIR}/../../..
> >>>
> >>
> >> If you do cd sys/modules/dtrace/dtraceall && make [obj depend] all, does
> >> it compile OK with the above change?
> >
> > Depends on your expectations I guess. As neither NFS-related option gets
> > defined, no dependency on either NFS module is registered. The compiler has
> > no complaints, though.
>
> Interesting. Could you repeat after sufficient cleaning up?
> I am not sure where from opt_nfs.h file could come.The Makefile seems to create an empty one: fk@r500 /usr/src/sys/modules/dtrace/dtraceall $make clean rm -f export_syms dtraceall.ko dtraceall.kld dtraceall.o dtraceall.ko.debug dtraceall.ko.symbols opt_compat.h opt_nfs.h fk@r500 /usr/src/sys/modules/dtrace/dtraceall $make echo "#define COMPAT_FREEBSD32 1" >> opt_compat.h :> opt_nfs.h cc -O2 -pipe [...] -c /usr/src/sys/modules/dtrace/dtraceall/dtraceall.c ld -d -warn-common -r -d -o dtraceall.ko.debug dtraceall.o :> export_syms awk -f /usr/src/sys/modules/dtrace/dtraceall/../../../conf/kmod_syms.awk dtraceall.ko.debug export_syms | xargs -J% objcopy % dtraceall.ko.debug objcopy --only-keep-debug dtraceall.ko.debug dtraceall.ko.symbols objcopy --strip-debug --add-gnu-debuglink=dtraceall.ko.symbols dtraceall.ko.debug dtraceall.ko Fabian
signature.asc
Description: PGP signature
