On Thu, Apr 22, 2010 at 10:05 AM, Eitan Adler <eitanadlerl...@gmail.com> wrote:
> Same as before - if all is good I'll send a PR
>
> #!/bin/sh
> #
> # $FreeBSD: src/etc/periodic/daily/210.backup-aliases,v 1.6.36.1.2.1
> 2009/10/25 01:10:29 kensmith Exp $
> #
>
> # If there is a global system configuration file, suck it in.
> #
> if [ -r /etc/defaults/periodic.conf ]
> then
>    . /etc/defaults/periodic.conf
>    source_periodic_confs
> fi
>
> bak=/var/backups
> db_loc=$(/usr/bin/make -f/usr/share/mk/bsd.port.mk -V PKG_DBDIR 2>/dev/null)
> bk_loc="$bak/pkgdb.bak.tar.bz2"
>
> case "$daily_backup_pkgdb_enable" in
>    [Yy][Ee][Ss])

This could be done via rc.subr's checkyesno function.

>        if [ ! -d $db_loc ]

Please quote the string.

>        then
>            echo '$daily_backup_pkgdb_enable is enabled but' \
>                "$db_loc doesn't exist"
>            rc=2
>        else
>            rc=0
>
>            echo ""
>            echo "Backing up package db directory:"
>
>            [ -e $bk_loc ] && unlink $bk_loc

Please quote.

>            tar -cjf $bk_loc $db_loc || rc=3

Same here.

>        fi;;
>
>    *)  rc=0;;
> esac
>
> exit $rc

Thanks,
-Garrett
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"

Reply via email to