Andrey V. Elsukov wrote: > [EMAIL PROTECTED] wrote: >> Synopsis: [ipfw] [patch] add support to ToS IP PRECEDENCE fields >> Responsible-Changed-From-To: freebsd-bugs->freebsd-ipfw >> Responsible-Changed-By: araujo >> Responsible-Changed-When: Tue Feb 26 19:08:49 UTC 2008 >> Responsible-Changed-Why: Over to maintainer(s). >> http://www.freebsd.org/cgi/query-pr.cgi?pr=121122 > > Hi, Marcelo. > > I talked to Roman when he submitted his first patch about > it's design. What you think about making TOK_SETIPTOSPRE not > an action, but a modifier? I think it will be much usable. > A syntax example: > > # ipfw add allow iptospre flashover ip from any to any > # ipfw add count iptospre immediate ip from anyt to any > # ipfw add skipto .... > > Also I talked to Roman about extensible variant of this ability. > A syntax example: > > <action> [{modip [DF|TOS|DSCP|TTL]}] <rule body>
I agree with you, this syntax looks cleaner, however when I was writing my patches I just needed to have the things working and haven't had much time improving/extending this feature. > Also look into: > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/102471 > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/103454 > > I added to CC several men who are active in ipfw area. > It will be interested what you think about this? > > -- > WBR, Andrey V. Elsukov Roman Bogorodskiy
pgpLMiMw6yYkZ.pgp
Description: PGP signature
