https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238089
--- Comment #78 from Alex Levy <a13xl...@gmail.com> ---
(In reply to Mark Linimon from comment #77)
I gave a try to reformat to be as close as the original Makefile but my
Makefile is drastically different than the original one as it's based on
pulling the sources from github and the buid process is different.
Also order of things in the original Makefile doesn't follow the porter's
handbook recommendation (section 15), not sure if it's a blocker but portlint
complains about it so I ordered my Makefile accordingly.
I don't think we can easily compare the 2 Makefiles with a diff even if I
change indentation and order of things. I can instead explain the differences
here if it helps (in order of appearance in the original Makefile) :
- I removed ONLY_FOR_ARCHS as I cannot say for sure that it builds on these
platforms.
- The dependencies are almost the same except there is no need for run
dependency on PY_PILLOW and no dependency at all on Perl.
- No need for a MONOLITE option (${GMAKE} get-monolite-latest in pre-build
covers it).
- I removed the X11 option as configure script doesn't seem to expose any
related parameters.
- I added DTRACE and BTLS options but they were not required per-se. The
original Makefile was configuring with --enable-btls and --disable-dtrace
hardcoded.
- GNU_CONFIGURE, LD_CONFIG are same
- SHEBANG_FILES differs because paths of scripts are different
- USE_PERL5, BINARY_ALIAS, MAKE_ENV, TEST_* and PORTSCOUT (should I keep this
one?) are gone.
- No need for the conditional on ${LOCALBASE}/bin/mcs.
- I added a pre-build that fetches monolite as instructed in
https://www.mono-project.com/docs/compiling-mono/compiling-from-git/
- There is no post-patch, no post-configure and no post-extract*
- post-install is the same, I just strip libmono-btls-shared.so as
INSTALL_TARGET=install-strip didn't do the trick for this one.
Hope that it helps.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-mono@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-mono
To unsubscribe, send any mail to "freebsd-mono-unsubscr...@freebsd.org"
