Thus spake Brooks Davis ([EMAIL PROTECTED]):

People. This is a good example why style fixes shouldn't happen
with content fixes.  I can't figure out what changed in this file:

> RCS file: /home/ncvs/src/sys/modules/Makefile,v
> retrieving revision 1.190
> diff -u -r1.190 Makefile
> --- sys/modules/Makefile      2001/07/08 04:17:26     1.190
> +++ sys/modules/Makefile      2001/07/13 23:10:49


> diff -u -r1.6 if_faith.c
> --- sys/net/if_faith.c        2001/07/05 14:42:54     1.6
> +++ sys/net/if_faith.c        2001/07/14 01:21:02

I'm just curious:  Why don't you need to include sys/module.h?
You don't include any other file that itself includes it, but
module.h defines DECLARE_MODULE and friends, which you are using.
I'm a little bit confused :-)

> +#include <machine/bus.h>     /* XXX: Shouldn't really be required! */

Why do you include it then? :-)

Haven't looked at the other stuff.

Thanks

Alex

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-net" in the body of the message

Reply via email to