[EMAIL PROTECTED] wrote:
The one who wrote that diff, whoever he is, obviously don't
understand C code.
Otherwise, why would he write such nonsense:
static uint32_t
iwi_toggle_event(uint32_t r)
{
r &= ~IWI_RST_STANDBY;
if (r & IWI_RST_GATE_ODMA)
r &= ~IWI_RST_GATE_ODMA;
if (r & IWI_RST_GATE_IDMA)
r &= ~IWI_RST_GATE_IDMA;
if (r & IWI_RST_GATE_ADMA)
r &= ~IWI_RST_GATE_ADMA;
return r;
}
when you could just write:
r &= ~(IWI_RST_STANDBY | IWI_RST_GATE_ODMA |
IWI_RST_GATE_IDMA | IWI_RST_GATE_ADMA);
but he sure knows how to steel code from others and
violate the GPL by the way:
From Linux ipw2200-1.1.0 (GPL):
static u32 ipw_register_toggle(u32 reg)
{
reg &= ~IPW_START_STANDBY;
if (reg & IPW_GATE_ODMA)
reg &= ~IPW_GATE_ODMA;
if (reg & IPW_GATE_IDMA)
reg &= ~IPW_GATE_IDMA;
if (reg & IPW_GATE_ADMA)
reg &= ~IPW_GATE_ADMA;
return reg;
}
...mmm very similar right?
I'm glad you see ways to improve the code. As to concerns about GPL
contamination you are way off base. Oh and of course I wrote this
code--as you knew all along.
Sam
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
