On Tue, 13 Feb 2007, Alexander Motin wrote:

Hi,

--- ng_l2tp.c.orig      Sat Feb 10 06:58:03 2007
+++ ng_l2tp.c   Sat Feb 10 06:58:00 2007
@@ -1121,6 +1121,10 @@

        /* If ack is still outstanding, send a ZLB */
-       if (seq->xack != seq->nr)
+       if (seq->xack != seq->nr) {
                ng_l2tp_xmit_ctrl(priv, NULL, seq->ns);
+               /* If there was memory error, ignore it.
+                  We must keep state consistent here. */
+               seq->xack = seq->nr;
+       }

This change is not needed. ng_l2tp_xmit_ctrl() does this already.

It's not a good idea to remove the L2TP_SEQ_CHECK()s.
Been there years ago but seems I missed to get this fixed
in the FreeBSD repo.
The problem is in ng_l2tp_seq_check(). Fix it there.

/bz

--
Bjoern A. Zeeb                          bzeeb at Zabbadoz dot NeT
_______________________________________________
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to