hrs added a comment.
Adding jumbo frame support looks good to me. However, is it better to
support this in ether_ioctl() instead of a driver-specific ioctl handler?
Check of (ifr->ifr_mtu > ETHERMTU) in ether_ioctl() can be changed to check if
the interface has IFCAP_JUMBO_MTU or not.
INLINE COMMENTS
> if_vxlan.c:2273
> + case SIOCSIFMTU:
> + if (ifr->ifr_mtu < ETHERMIN || ifr->ifr_mtu > ETHERMTU_JUMBO) {
> + error = EINVAL;
I think the maximum value should be calculated by considering encap overhead.
VXLAN adds a header with 50-100 byte long depending on the outer protocol.
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D19422/new/
REVISION DETAIL
https://reviews.freebsd.org/D19422
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: aleksandr.fedorov_itglobal.com, bryanv, hrs, #network, rgrimes
Cc: evgueni.gavrilov_itglobal.com, olevole_olevole.ru, ae, freebsd-net-list,
krzysztof.galazka_intel.com
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
