On 07/09/10 05:27, John Baldwin wrote:
> On Thursday, July 08, 2010 6:12:39 pm Doug Barton wrote:
>> On Thu, 8 Jul 2010, John Baldwin wrote:
>>
>>> This is a port for yet-another-/etc-merging tool that I wrote recently.
> It
>>> passes portlint -N with one bogus warning because /etc is in the comment.
>>
>> I didn't try installing/deinstalling but you seem to have the right
>> stuff in the Makefile for that. Overall it looks good, just a couple
>> comments:
>> 1. I don't think textproc is right for CATEGORIES, although sysutils is
>> of course.
>> 2. I don't think the do-fetch target is necessary, but if it is needed
>> when you test it that's fine.
>> 3. You have a pkg-descr~ file in the shar that should be deleted before
>> you commit it.
>>
>> Assuming it passes all the tests in the porter's handbook for install,
>> deinstall, package, etc. I'd say go ahead. :)
>
> Ok. Should I fix 1) and 2) for the sysutils/etcmerge port as well? (I used
> etcmerge as a template.)
I think removing textproc is a no-brainer, unless someone has a
different opinion. :) I don't have a do-fetch target in portmaster's
port (which also has the src in the tree), and given the fact that
DISTFILES is explicitly set empty I don't see why one would be necessary
at all.
So, short answer, yes, if you don't mind. Otherwise I'll be glad to do
it, just let me know.
Doug
--
... and that's just a little bit of history repeating.
-- Propellerheads
Improve the effectiveness of your Internet presence with
a domain name makeover! http://SupersetSolutions.com/
_______________________________________________
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
