On 19 July 2012 18:04, Jason Hellenthal <jhellent...@dataix.net> wrote: > > It seems that the usage of SAMBA_PORT= var has been confused quite a > bit. > > SAMBA_PORT= as judged by ports/net/samba* is defined to be "net/samba??" > while ports/net/samba-libsmbclient defines it as "samba??" > > I found when creating index that no matter which way you define it both > of the two ways will end up indicating failure for different ports > because /usr/ports/samba?? does not exist or /usr/ports/net/net/samba?? > does not exist. > > Can someone please go through these ports and unify there usage of > SAMBA_PORT. > > /usr/ports/net/samba-libsmbclient/Makefile:16:SAMBA_PORT= > samba34 > /usr/ports/net/samba-libsmbclient/Makefile:19:MASTERDIR= > ${.CURDIR}/../${SAMBA_PORT} > /usr/ports/net/samba-nmblookup/Makefile:16:SAMBA_PORT= samba34 > /usr/ports/net/samba-nmblookup/Makefile:19:MASTERDIR= > ${.CURDIR}/../${SAMBA_PORT} > /usr/ports/net/samba-pdbsql/Makefile:23:SAMBA_PORT?= net/samba34 > /usr/ports/net/samba-pdbsql/Makefile:30:SAMBA_WRKSRC!= cd > ${PORTSDIR}/${SAMBA_PORT} && ${MAKE} -V WRKSRC > /usr/ports/net/samba-pdbsql/Makefile:34:SAMBA_MODULEDIR!= cd > ${PORTSDIR}/${SAMBA_PORT} && ${MAKE} -V SAMBA_MODULEDIR > /usr/ports/net/samba-pdbsql/Makefile:40:BUILD_DEPENDS+= > ${NONEXISTENT}:${PORTSDIR}/${SAMBA_PORT}:configure > /usr/ports/net/samba-smbclient/Makefile:16:SAMBA_PORT= samba36 > /usr/ports/net/samba-smbclient/Makefile:21:MASTERDIR= > ${.CURDIR}/../${SAMBA_PORT} > /usr/ports/net/samba4-devel/Makefile:7:PORTNAME?= > ${SAMBA_PORTNAME} > /usr/ports/net/samba4-devel/Makefile:23:SAMBA_PORTNAME= samba4 > /usr/ports/net/samba4-devel/Makefile:25:SAMBA_DISTNAME= > ${SAMBA_PORTNAME:S|4$||}-${SAMBA_VERSION:S|.p|pre|:S|.r|rc|:S|.t|tp|:S|.a|alpha|} > /usr/ports/net/samba4-devel/Makefile:26:OPTIONSFILE= > ${PORT_DBDIR}/${SAMBA_PORTNAME}/options > /usr/ports/net/samba4-devel/Makefile:187:USE_RC_SUBR= > ${SAMBA_PORTNAME}
I've usually seen category/port used. I'm sure Timur will have a look, but for quicker results you could send a PR with a patch. Chris _______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"