On 2012-Nov-04, 08:48, Joseph a Nagy Jr wrote: > On 11/02/12 06:21, Pietro Cerutti wrote: > > On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote: > >> On 10/31/12 11:55, Pietro Cerutti wrote: > >>> On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: > >> <snip> > >>>> New diff[0], undoing some of the earlier changes even though portlint > >>>> complains: > >>>> > >>>> portlint ~/port-maintenance/tk85/ > >>>> WARN: Makefile: unless this is a master port, COMMENT has to be set by > >>>> "=", not by "?=". > >>> > >>> This *is* a master port, so it's ok to have COMMENT?= > >>> > >>>> WARN: Makefile: "LIB_DEPENDS" has to appear earlier. > >>> > >>> This should be fixed as portlint suggests. > >>> > >>>> WARN: Makefile: no port directory > >>>> /usr/ports/lang/tcl${SHORT_TK_VER}-thread found, even though it is > >>>> listed in LIB_DEPENDS. > >>> > >>> I would try and use USE_TCL instead of LIB_DEPENDS here > >>> > >>>> WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in > >>>> Xft.2 unless it is really necessary. > >>> > >>> This should be fixed as portlint suggests. > >>> > >>>> 0 fatal errors and 4 warnings found. > >>>> > >>>> [0]: http://pastebin.com/apf1Y9H0 > >>> > >>> I'll have a look at it on Friday, thanks! > >>> > >>> > >> > >> Going ahead to make those changes, old pastebin link is defunct. > >> > >> New diff with all changes: > >> http://pastebin.com/iwhpXfcp > > > > This won't apply, either. Could you provide a diff as dumped by svn diff > > in tk85's directory? > > > > Try this diff: > http://pastebin.com/9YacWnss
* I won't comment on the LICENSE stuff, I don't know enough about it * XFT_DESC This is already defined in bsd.options.desc.mk. I'd say that "Xft font library" is ok as a description. * LIB_DEPENDS+= Xft:${PORTSDIR}/x11-fonts/libXft This should really be USE_XORG+= xft * LIB_DEPENDS= tcl${SHORT_TK_VER}${THREADS_SUFFIX}:.... If you're ok to wait until I get rid of the -thread slave ports, you don't need to bother about this part of the Makefile -- Pietro Cerutti The FreeBSD Project g...@freebsd.org PGP Public Key: http://gahr.ch/pgp
pgprpYlO1sP79.pgp
Description: PGP signature