On Sep 20, 2013, at 22:37, Bryan Drewery <br...@shatow.net> wrote: > On Fri, Sep 20, 2013 at 06:57:52PM +0100, Big Lebowski wrote: >> Hi list! >> >> I've been working for couple last days on porting Basho Riak database >> (latest version 1.4.2) and finally I think it is ready to be presented: >> https://www.dropbox.com/s/2ztu2bdiip1u2un/riak.tgz > > MASTER_SITES= http://s3.amazonaws.com/downloads.basho.com/riak/1.4/1.4.2/ \ > http://downloads.basho.com.s3.amazonaws.com/riak/1.4/1.4.2/ > > Use ${PORTVERSION} instead of 1.4.2 > > USES= ${GMAKE} > > Use 'gmake', not ${GMAKE} here. > > Fails to build on 8.3 i386: > > db/version_set.cc:59: warning: this decimal constant is unsigned only in ISO > C90 > db/version_set.cc:59: warning: this decimal constant is unsigned only in ISO > C90 > db/version_set.cc:60: error: integer constant is too large for 'long' type > db/version_set.cc:60: error: integer constant is too large for 'long' type > db/version_set.cc:61: error: integer constant is too large for 'long' type > db/version_set.cc:61: error: integer constant is too large for 'long' type > db/version_set.cc:62: error: integer constant is too large for 'long' type > db/version_set.cc:62: error: integer constant is too large for 'long' type > table/filter_block.cc: In member function 'bool > leveldb::FilterBlockReader::KeyMayMatch(uint64_t, const leveldb::Slice&)': > table/filter_block.cc:112: warning: comparison between signed and unsigned > integer expressions > util/env_posix.cc: In constructor 'leveldb::<unnamed>::PosixEnv::PosixEnv()': > util/env_posix.cc:788: warning: unused variable 'ts'
Yes, this only seems to occur when compiling the port with gcc, but the constants in that array are not defined in a portable way. Please drop the attached patch file in databases/riak/files/, that should fix it. Maybe it should go upstream, even. -Dimitry
patch-deps-eleveldb-c_src-leveldb-db-version_set.cc
Description: Binary data
signature.asc
Description: Message signed with OpenPGP using GPGMail
