Hi Sergey, could you clarify which parts you believe are features?
I know there are a number of changes but all of them I'd class as fixes and not really features. For reference here's a description of the changes:- * Added missing license * Display the correct install message for both nginx and apache * Fix staging build of nginx, apache and link components * Ensure download_cache is included in the package which prevents warning on removal due to failure to delete directory. * Updated LIB_DEPENDS to latest recommended format Just to be sure we're both talking about the same changes I've attached the latest version for reference. Regards Steve----- Original Message ----- From: "Sergey A. Osokin" <o...@freebsd.org>
To: "Steven Hartland" <kill...@multiplay.co.uk> Cc: "FreeBSD Ports" <po...@freebsd.org>; "Scot Hetzel" <swhet...@gmail.com>; "David Keller" <david.kel...@litchis.fr> Sent: Tuesday, April 15, 2014 12:00 AM Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2
Hi Steven, unfortunately, your patch is wrong and this is why I can't commit your changes. What's wrong in your patch? You have mixed features and bugfixes in one patch. Please provide bugfix only patch. -- ozz On Sun, Apr 13, 2014 at 12:28:41PM +0100, Steven Hartland wrote:----- Original Message ----- From: "David Keller" <david.kel...@litchis.fr> >Hi Sergey, > >It's not related to gem dependency error but the symlink creation >might be incorrect: >${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME} > >Will create the following symlink: >/usr/local/lib/ruby/gems/1.9/gems/passenger -> >lib/ruby/gems/1.9/gems/passenger-4.0.41 > >Rather than: >/usr/local/lib/ruby/gems/1.9/gems/passenger -> >/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41 > >Or: >/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41 > > >You might prefer using: >${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME} >${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME} > >Or even: >${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME} My current version has: (cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s ${GEM_NAME} ${PORTNAME}) Which I will create: /usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41 @Sergey: For your apache module problem try the attached patch / full version which fixes that for me. I'd previously only ever built the nginx version and looks like the apache2 module build was broken when stage support was added. I've confirmed it builds but I don't have an apache2 install to test fully with here so if you could let me know if it works and I'll get all the changes checked in. Regards Steve_______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
rubygem-passenger.patch
Description: Binary data
_______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
