On Tue, 4 Oct 2016 14:15:28 +0200 Mathieu Arnold <m...@freebsd.org> wrote:
> Le 04/10/2016 à 14:03, Montgomery-Smith, Stephen a écrit : > > On 10/04/2016 06:47 AM, Mathieu Arnold wrote: > >> Le 04/10/2016 à 09:29, Eitan Adler a écrit : > >>> On 4 October 2016 at 00:25, Mathieu Arnold <m...@freebsd.org> > >>> wrote: > >>>> Le 04/10/2016 à 03:58, Montgomery-Smith, Stephen a écrit : > >>>>> Could we use USES=metaport to suppress these messages? > >>>> Suppress what messages ? > >>> 115 .if defined(LICENSE) > >>> 119 .else > >>> 120 DEV_WARNING+= "Please set LICENSE for this port" > >>> 121 .endif > >> Mmmm, this is a warning, not an error, it tells you "dude, maybe > >> you need to do this". > >> I don't see a good reason to complicate the logic more. > >> > > Because naive port maintainers like myself might think they should > > add a LICENSE to any metaport they happen to own. > > > > One of the issues I have with LICENSE is that I don't see anything > > about it in the porters handbook. Otherwise that would be an > > excellent place to tell maintainers of metaports not to license > > them. > > Nobody stepped up to write a LICENSE section. I started writing > https://reviews.freebsd.org/D56 but it is crappy. > > > Also the tone is quite commanding. If it said "Consider setting > > LICENSE for this port", that would be more acceptable. Really, I > > think it should say "Please set LICENSE for this port, unless this > > is a metaport". > > Feel free to make the message better, it is in Mk/bsd.sanity.mk. I believe portlint uses 'Consider'. On the other hand, I had a new port and the committer insisted I had LICENSE in there. _______________________________________________ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"