On 2017/11/09 09:30, Ryan Steinmetz wrote: > On (11/08/17 20:31), John W. O'Brien wrote: >> On 2017/11/07 19:16, Ryan Steinmetz wrote: >>> On (11/06/17 22:11), John W. O'Brien wrote: >>>> Hello FreeBSD ports, >>>> >>>> The maintainer of net/freeradius3 is unresponsive on two open bugs, >>>> both >>>> with proposed patches. >>> >>> John, >>> >>> I was reviewing these two issues tonight and, if I am not mistaken, the >>> IDN issue was resolved in a commit on 7/17/17: >>> https://svnweb.freebsd.org/ports/head/net/freeradius3/pkg-plist?r1=442287&r2=446076 >>> >> >> Hi Ryan, >> >> The change you cite allows the port to build with the IDN option. >> However, it appears that this fragment of the Makefile needs some TLC. >> Is the IDN module experimental or not? > > To me, this feels a little nit-picky and isn't something that an > end-user is actually going to see.
Are port OPTIONS for end-users? >> # freetds module is still experimental >> .if ${PORT_OPTIONS:MIDN} && empty(PORT_OPTIONS:MEXPERIMENTAL) >> EXPM= yes >> .endif >> >>> I also believe that the Kerberos issue was resolved on 4/1/16: >>> https://svnweb.freebsd.org/ports/head/net/freeradius3/Makefile?r1=412347&r2=412348& >>> >>> >>> Can you please verify your ports tree is current (you should see >>> FreeRADIUS 3.0.15) and then confirm/deny? >> >> $ svn info /usr/ports | grep Revision >> Revision: 453233 >> $ svn log -v -r 453233:HEAD /usr/ports/net/freeradius3 >> ------------------------------------------------------------------------ >> >> The issue persists. Here are some relevant excerpts from a poudriere >> testport build. >> > > OK so MIT Kerberos integration isn't 100%, but the Heimdal stuff works. > > I'll check this out. Please see the PR for more details and a proposed solution. I would be glad to help review a refreshed patch. >> [...] >> ---Begin OPTIONS List--- >> ===> The following configuration options are available for >> freeradius3-3.0.15_1: >> DEVELOPER=off: Enable developer options >> DOCS=off: Build and/or install documentation >> EDIR=off: Enable eDirectory support (implies LDAP) >> EXPERIMENTAL=off: Build experimental modules >> FIREBIRD=off: With Firebird database support (EXPERIMENTAL) >> FREETDS=off: FreeTDS library support >> HEIMDAL=off: With Heimdal Kerberos support >> HEIMDAL_PORT=off: With Heimdal Kerberos from ports >> IDN=off: International Domain Names support >> KERBEROS=on: Kerberos support >> LDAP=off: LDAP protocol support >> MYSQL=off: MySQL database support >> PERL=on: Perl scripting language support >> PGSQL=off: PostgreSQL database support >> PYTHON=off: Python bindings or support >> REDIS=off: Redis key-value store database support >> REST=off: Enable RESTful API support >> RUBY=off: Ruby bindings or support >> SQLITE3=off: SQLite 3 database support >> UDPFROMTO=off: Compile in UDPFROMTO support >> UNIXODBC=off: With unixODBC database support >> USER=on: Run as user freeradius, group freeradius >> ===> Use 'make config' to modify these settings >> ---End OPTIONS List--- >> >> --CONFIGURE_ARGS-- >> --without-rlm_sql_sqlite --with-rlm_krb5 >> --with-rlm-krb5-lib-dir=/usr/local/lib --wi >> th-rlm-krb5-include-dir=/usr/local/include --without-edir >> --without-rlm_ldap --without-rlm_sql_mysql --without-rlm_sql_postgresql >> --without-rlm_sql_unixodbc --without-rlm_sql_firebird --with-rlm_perl >> --without-rlm_python --without-rlm_ruby --with-ruby=no >> --without-rlm_redis --without-rlm_rediswho --without-rlm_rest >> --without-rlm_freetds --without-rlm_idn --without-experimental-modules >> --quiet --without-docdir --with-openssl-libraries=/usr/local/lib >> --with-logdir=/var/log --with-openssl-includes=/usr/local/include >> --prefix=/usr/local --libdir=/usr/local/lib/freeradius-3.0.15 >> --localstatedir=/var --without-rlm_eap_ikev2 --without-rlm_eap_tnc >> --without-rlm_eap2 --without-rlm_opendirectory --without-rlm_sql_db2 >> --without-rlm_sql_iodbc --without-rlm_sql_sybase --without-rlm_yubikey >> --without-rlm_sql_oracle --without-rlm_securid >> --without-rlm_cache_memcached --with-vmps >> --with-collectdclient-lib-dir=/dev/null --disable-openssl-version-check >> --with-pic --prefix=/usr/local ${_LATE_CONFIGURE_ARGS} >> --End CONFIGURE_ARGS-- >> >> --CONFIGURE_ENV-- >> MAKE=gmake ac_cv_path_PERL=/usr/local/bin/perl >> ac_cv_path_PERL_PATH=/usr/local/bin/perl PERL_USE_UNSAFE_INC=1 >> XDG_DATA_HOME=/wrkdirs/usr/ports/net/freeradius3/work >> XDG_CONFIG_HOME=/wrkdirs/usr/ports/net/freeradius3/work >> HOME=/wrkdirs/usr/ports/net/freeradius3/work TMPDIR="/tmp" >> PATH=/wrkdirs/usr/ports/net/freeradius3/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin >> >> SHELL=/bin/sh CONFIG_SHELL=/bin/sh >> CONFIG_SITE=/usr/ports/Templates/config.site lt_cv_sys_max_cmd_len=262144 >> --End CONFIGURE_ENV-- >> >> --MAKE_ENV-- >> OPENSSLBASE=/usr/local OPENSSLDIR=/usr/local/openssl >> OPENSSLINC=/usr/local/include OPENSSLLIB=/usr/local/lib >> OPENSSLRPATH=/usr/local/lib PERL_USE_UNSAFE_INC=1 >> XDG_DATA_HOME=/wrkdirs/usr/ports/net/freeradius3/work >> XDG_CONFIG_HOME=/wrkdirs/usr/ports/net/freeradius3/work >> HOME=/wrkdirs/usr/ports/net/freeradius3/work TMPDIR="/tmp" >> PATH=/wrkdirs/usr/ports/net/freeradius3/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin >> >> NO_PIE=yes WITHOUT_DEBUG_FILES=yes WITHOUT_KERNEL_SYMBOLS=yes >> SHELL=/bin/sh NO_LINT=YES PREFIX=/usr/local LOCALBASE=/usr/local >> LIBDIR="/usr/lib" CC="cc" CFLAGS="-O2 -pipe -I/usr/local/include >> -fstack-protector -fno-strict-aliasing" CPP="cpp" >> CPPFLAGS="-I/usr/local/include" LDFLAGS=" -L/usr/local/lib >> -Wl,-rpath,/usr/local/lib -fstack-protector" LIBS="" CXX="c++" >> CXXFLAGS="-O2 -pipe -I/usr/local/include -fstack-protector >> -fno-strict-aliasing " MANPREFIX="/usr/local" >> BSD_INSTALL_PROGRAM="install -s -m 555" BSD_INSTALL_LIB="install -s >> -m 0644" BSD_INSTALL_SCRIPT="install -m 555" >> BSD_INSTALL_DATA="install -m 0644" BSD_INSTALL_MAN="install -m 444" >> --End MAKE_ENV-- >> [...] >> CC src/modules/proto_dhcp/rlm_dhcp.c >> In file included from src/modules/rlm_krb5/krb5.c:28: >> src/modules/rlm_krb5/krb5.h:41:2: error: unknown type name >> 'krb5_verify_opt' >> krb5_verify_opt options; >> ^ >> src/modules/rlm_krb5/krb5.c:151:2: warning: implicit declaration of >> function 'krb5_verify_opt_init' is invalid in C99 >> [-Wimplicit-function-declaration] >> krb5_verify_opt_init(&conn->options); >> ^ >> src/modules/rlm_krb5/krb5.c:152:2: warning: implicit declaration of >> function 'krb5_verify_opt_set_ccache' is invalid in C99 >> [-Wimplicit-function-declaration] >> krb5_verify_opt_set_ccache(&conn->options, conn->ccache); >> ^ >> src/modules/rlm_krb5/krb5.c:154:2: warning: implicit declaration of >> function 'krb5_verify_opt_set_keytab' is invalid in C99 >> [-Wimplicit-function-declaration] >> krb5_verify_opt_set_keytab(&conn->options, conn->keytab); >> ^ >> src/modules/rlm_krb5/krb5.c:155:2: warning: implicit declaration of >> function 'krb5_verify_opt_set_secure' is invalid in C99 >> [-Wimplicit-function-declaration] >> krb5_verify_opt_set_secure(&conn->options, true); >> ^ >> src/modules/rlm_krb5/krb5.c:157:21: warning: implicit declaration of >> function 'krb5_verify_opt_set_service' is invalid in C99 >> [-Wimplicit-function-declaration] >> if (inst->service) krb5_verify_opt_set_service(&conn->options, >> inst->service); >> ^ >> 5 warnings and 1 error generated. >> gmake[1]: *** [scripts/boiler.mk:636: >> build/objs/src/modules/rlm_krb5/krb5.lo] Error 1 >> gmake[1]: *** Waiting for unfinished jobs.... >> In file included from src/modules/rlm_krb5/rlm_krb5.c:32: >> src/modules/rlm_krb5/krb5.h:41:2: error: unknown type name >> 'krb5_verify_opt' >> krb5_verify_opt options; >> ^ >> src/modules/rlm_krb5/rlm_krb5.c:347:8: warning: implicit declaration of >> function 'krb5_verify_user_opt' is invalid in C99 >> [-Wimplicit-function-declaration] >> ret = krb5_verify_user_opt(conn->context, client, >> request->password->vp_strvalue, &conn->options); >> ^ >> 1 warning and 1 error generated. >> gmake[1]: *** [scripts/boiler.mk:637: >> build/objs/src/modules/rlm_krb5/rlm_krb5.lo] Error 1 >> gmake[1]: Leaving directory >> '/wrkdirs/usr/ports/net/freeradius3/work/freeradius-server-3.0.15' >> ===> Compilation failed unexpectedly. >> >> >>>> In one case [0], the submitter responded to feedback on 2016-02-03, >>>> there has been no further action on the part of the maintainer, and the >>>> port remains broken w.r.t. Kerberos. >>>> >>>> In the other case [1], there was already one maintainer timeout (5 >>>> mo as >>>> of 2016-07-17). The bug was reassigned to the maintainer on 2017-08-18, >>>> and there has been no further action. >>>> >>>> I would appreciate it if somebody could give these bugs the attention >>>> they need. >>>> >>>> Also, I ask that if the maintainer is unable or unwilling to attend to >>>> reported problems, that the port be released so that others could more >>>> easily work to improve it. >>>> >>>> Regards, >>>> John >>>> >>>> [0] net/freeradius3: Fix pkg-plist with IDN option >>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202684 >>>> [1] net/freeradius3: Does not link properly against selected kerberos >>>> implementation >>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205493 >>>> >>> >>> >>> >>> >> >> > > > >
signature.asc
Description: OpenPGP digital signature