Eugene Grosbein wrote on 01/07/2018 22:12:
08.01.2018 4:00, Miroslav Lachman wrote:
PRs are false alibi. Some of my PRs are open for more than 10 years.
So were mine when I could not commit fixes myself. This is not excuse to be
lazy and not make another one.
For all erroneous port there must be will on maintainer and committer side.
And if "they" think this is not a bug
If we have written policy (and we have in this case), and upgrade really break
things,
sane committer will not think "this is not a bug".
Again, do you have a PR with "how-to-repeat" scenario and a patch,
so I could take it?
OK, let's move on. I can open PR if you are willing to help and commit
some fixes. But can we first talk about what and how should be done?
What is the right way to handle Apache module install / deinstall /
upgrade? Because some modules are using code from Mk/bsd.apache.mk which
do the wrong thing:
.if defined(AP_FAST_BUILD)
.if !target(ap-gen-plist)
_USES_build+= 490:ap-gen-plist
ap-gen-plist:
.if defined(AP_GENPLIST)
. if !exists(${PLIST})
@${ECHO} "===> Generating apache plist"
@${ECHO} "%%APACHEMODDIR%%/%%AP_MODULE%%" >> ${PLIST}
@${ECHO} "@postexec %D/sbin/apxs -e ${AP_MOD_EN} -n %%AP_NAME%%
%D/%F" >> ${PLIST}
@${ECHO} "@postunexec ${SED} -i '' -E
'/LoadModule[[:blank:]]+%%AP_NAME%%_module/d'
%D/%%APACHEETCDIR%%/httpd.conf" >> ${PLIST}
@${ECHO} "@postunexec echo \"Don't forget to remove all
${MODULENAME}-related directives in your httpd.conf\"">> ${PLIST}
. endif
.endif
.endif
Some modules did similar thing in Makefile (or they did in the past).
1) Should install put something in to httpd.conf?
2) Should deinstall or upgrade remove something from httpd.conf?
3) Or as I suggested here
https://lists.freebsd.org/pipermail/freebsd-ports/2017-October/110725.html
should each module install own sample file in apache24/modules.d/?
Miroslav Lachman
_______________________________________________
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
