https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233781
Kubilay Kocak <ko...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |maintainer-feedback?(soboma
| |x...@freebsd.org)
Severity|Affects Only Me |Affects Some People
CC| |ko...@freebsd.org,
| |sobo...@freebsd.org
Status|New |Open
Summary|devel/py-freebsd: fix with |devel/py-freebsd: Update to
|python 3.x and upgrade to |0.9.4, Fix with python 3.x
|version 0.9.4 |support
Keywords| |needs-patch, needs-qa
--- Comment #2 from Kubilay Kocak <ko...@freebsd.org> ---
Thank you Maxim. A couple of review items:
1) GH_TAGNAME= v${PORTVERSION} - Use DISTVERSIONPREFIX=v, drop GH_TAGNAME
2) Can you provide detail or explanation (and include in the commit message
after approval) of:
a) the upstream change. Is it a fork, did you transfer/coordinate with perky to
move it to GitHub?
b) The patch removals. Were they upstreamed? No longer necessary?
3) Since it appears the upstream is not hosted under your GitHub account, would
you like to update MAINTAINER to yourself? Please include that change if so.
4) The package includes tests. Can you add TEST_DEPENDS (if necessary) and a
test target to run them. Ideally this should be integrated upstream, using
setup.py test (setup.py:tests_require,test_suite, et al)
5) Was Python 3 support supposed to work prior to this, but was broken? Or was
Python 3 support recently added upstream and in this version? If the latter,
update the issue summary (and commit log message) to say 'Enable Python3.x
support' rather than 'Fix Python 3.x support'
Longer term (not for this commit), can we look at distributing/publishing this
to PyPI (CHEESESHOP). In particular, it would be good to have a 'registered'
and canonical name for this package. Right now the portname is 'freebsd', but
the actual upstream / distname is 'py-freebsd'. I'd go with just 'freebsd' for
PyPI, to match the current PORTNAME. It doesn't ultimate matter what the repo
name is.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
