On 18 January 2011 19:19, John Baldwin <j...@freebsd.org> wrote: > On Sunday, January 16, 2011 12:24:27 pm Sergey Kandaurov wrote: >> On 16 January 2011 06:10, <per...@pluto.rain.com> wrote: >> > Anyone had a chance to look at this? >> > >> > http://lists.freebsd.org/pipermail/freebsd-stable/2010-December/060793.html >> >> To ease testing on head I have regenerated the patch >> (against r216594): >> http://plukky.net/~pluknet/patches/msgbufsize.diff > > The one hunk involving tf_rip and PS_STRINGS in amd64 looks to be unrelated.
Woops, sorry. Nice catch! > Also, in subr_param.c, you can assume that MSGBUF_SIZE is always defined > and always assign it as the initial value rather than having an #ifdef. Good. > Finally, I would adjust the wording in the manpage to not say that this > modifies the MSGBUF_SIZE option, but that this tunable is the same as > adjusting MSGBUF_SIZE. Other than that I think it is fine. > Right. I think a simple s/Modifies/Overrides/ here will be enough. Thanks for your valuable comments. An updated patch is there: http://plukky.net/~pluknet/patches/msgbufsize.2.diff I'm going to commit this soon. -- wbr, pluknet _______________________________________________ freebsd-stable@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"