on 03/08/2011 00:03 Andriy Gapon said the following:
> I tried to run dtruss (as you did) and I got this pre-amble before the 
> assertion:
> [some dtrace script body]
> : probe description proc:::exit does not match any probes
> 
> I guess that in my case I got it because my userland was not compiled with CTF
> support.  Not sure about yours...
> 
> Of course, it's still rather bad that dtrace crashes when it prematurely 
> exits.
> But maybe it doesn't crash in the correct environment...  I don't know.

OK, here's a patch that should fix the abort via assertion - with this you
shouldn't get the crash that you've reported.

I hope that you will be able to tackle other conditions that dtrace considers to
be errors.

diff --git a/lib/libproc/proc_create.c b/lib/libproc/proc_create.c
index c372a47..9bd24a2 100644
--- a/lib/libproc/proc_create.c
+++ b/lib/libproc/proc_create.c
@@ -79,12 +79,11 @@ proc_attach(pid_t pid, int flags, struct proc_handle 
**pphdl)
        else
                phdl->status = PS_STOP;

+out:
        if (error)
                proc_free(phdl);
        else
                *pphdl = phdl;
-out:
-       proc_free(phdl);
        return (error);
 }



-- 
Andriy Gapon
_______________________________________________
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

Reply via email to