On 2012-11-05 17:28, Volodymyr Kostyrko wrote:
05.11.2012 18:00, Andriy Gapon wrote:
I bet on clang 3.2.
Thank you for checking.
So how do we proceed from here?
I could just revert the MFC-es, but the functionality could be desirable to some
users. Are there any alternatives?
Dunno, clang 3.2 is still pending so I guess it wouldn't be MFC'ed until
December 16th? Being a minor issue it can make some people shrug from
using clang for testing stable...
While clang 3.2 will be branched for release soon, and hopefully will be
released on the date you mention, it will probably not appear instantly
in head. We need to test it rather thoroughly, to see if there are no
unexpected side effects.
Even then, I would not merge it to stable/9 after at least a month of
settling in head.
I have also looked at merging the snapshot of 3.2 we now have in head to
stable/9, but it is also quite some work, so I found a better solution:
I managed to shrink boot2 by enough bytes to make it fit again.
I committed the change to head in r242804, and I will MFC it in 3 days,
if there are no regressions reported. Meanwhile, please apply the
attached patch.
-Dimitry
Index: sys/boot/i386/boot2/sio.S
===================================================================
--- sys/boot/i386/boot2/sio.S (revision 242667)
+++ sys/boot/i386/boot2/sio.S (working copy)
@@ -40,13 +40,11 @@ sio_init: pushl %eax
movb $0x3,%al # Set RTS,
outb %al,(%dx) # DTR
incl %edx # Line status reg
- call sio_flush
- ret
+ # Fallthrough
/* int sio_flush(void) */
-sio_flush: xorl %eax,%eax # Return value
- xorl %ecx,%ecx # Timeout
+sio_flush: xorl %ecx,%ecx # Timeout
movb $0x80,%ch # counter
sio_flush.1: call sio_ischar # Check for character
jz sio_flush.2 # Till none
_______________________________________________
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"
