On 2013-01-17 14:07, Kimmo Paasiala wrote:
On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis <bro...@freebsd.org> wrote:
...
NetBSD and OpenBSD use different signatures for strnvis(). :(
pam_ssh_agent_auth assumes that if the system has one it is the OpenBSD
one but ours is the NetBSD one. The port will need to be patched to use
the openbsd version like it was doing or to swap the second and third
arguments when build on newer versions of FreeBSD.
It turns out that security/pam_ssh_agent_auth compiles its own version
of strnvis() when HAVE_STRNVIS is not defined. This in turn results in
an exported dynamic strnvis symbol in the plugin binary. I guess
that's what is breaking things when the plugin binary is loaded on
post r245439 world.
First thing that comes to my mind for a fix is renaming the local
strnvis() to something else conditionally based on HAVE_STRNVIS.
Please try the following patch, which tells configure that HAVE_STRNVIS
is always false. I think this is the easiest way, unless we really want
the port to use our own strnvis.
Index: security/pam_ssh_agent_auth/Makefile
===================================================================
--- security/pam_ssh_agent_auth/Makefile (revision 310549)
+++ security/pam_ssh_agent_auth/Makefile (working copy)
@@ -16,6 +16,7 @@ COMMENT= PAM module which permits authentication v
USE_BZIP2= yes
GNU_CONFIGURE= yes
+CONFIGURE_ENV= ac_cv_func_strnvis="no"
CONFIGURE_ARGS= --libexecdir=${LOCALBASE}/lib
USE_PERL5= yes
_______________________________________________
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"
