----- Original Message ----- From: "Andre Oppermann" <an...@freebsd.org>

On 08.07.2013 16:37, Andre Oppermann wrote:
On 07.07.2013 20:24, Alfred Perlstein wrote:
On 7/7/13 1:34 AM, Andre Oppermann wrote:
Can you help me with with testing?

Yes.  Please give me your proposed changes and I'll stand up a machine and give 
feedback.

http://people.freebsd.org/~andre/mfc-autotuning-20130708.diff

Any feedback from testers on this?  The MFC window is closing soon.

Few things I've noticed most of which look like issues against the original
patch and not the MFC but worth mentioning.

1. You've introduced a new tunable kern.maxmbufmem which is autosized but
  doesnt seem to be exposed via a sysctl so it looks like there is no way
  to determine what its actually set to?
2. There's a missmatch between the tuneable kern.ipc.nmbufs in tunable_mbinit
  and the sysctl kern.ipc.nmbuf i.e. no 's'.
3. Should kern.maxmbufmem be kern.ipc.maxmbufmem to sit along side all of
  the other sysctls?
4. style issues:
* @@ -178,11 +202,13 @@
 ...
 if (newnmbjumbo9 > nmbjumbo9&&

Finally out of interest what made us arrive at the various defaults for each
type as it looks like the ratios have changed?

   Regards
   Steve

================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.
In the event of misdirection, illegible or incomplete transmission please 
telephone +44 845 868 1337
or return the E.mail to postmas...@multiplay.co.uk.

_______________________________________________
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

Reply via email to